-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize frontend files: move wcdl
and external-components
into components
#2722
Merged
eason9487
merged 9 commits into
develop
from
dev/195-reorganize-frontend-files-wcdl-and-external
Dec 13, 2024
Merged
Reorganize frontend files: move wcdl
and external-components
into components
#2722
eason9487
merged 9 commits into
develop
from
dev/195-reorganize-frontend-files-wcdl-and-external
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory and rename related CSS.
…archable-select-control` and rename related components and CSS.
… rename related CSS.
…and rename related CSS.
…ents/external` directory.
…ts/external` directory.
…ternal` directory.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2722 +/- ##
=======================================
Coverage 63.4% 63.4%
=======================================
Files 338 338
Lines 5203 5203
Branches 1274 1274
=======================================
Hits 3301 3301
Misses 1728 1728
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eason9487
force-pushed
the
dev/195-reorganize-frontend-files-wcdl-and-external
branch
from
December 13, 2024 01:56
8bf4aa5
to
b9b2831
Compare
eason9487
deleted the
dev/195-reorganize-frontend-files-wcdl-and-external
branch
December 13, 2024 02:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #195
This PR further reorganizes frontend files within two directories:
js/src/wcdl
components
directory and delete the README fileSelectControl
component toSearchableSelectControl
to differentiate it fromAppSelectControl
AppSelectControl
based onSelectControl
from@wordpress/components
SearchableSelectControl
based onSelectControl
from@woocommerce/components
wcdl-
togla-
for all related CSS classesjs/src/external-components
components/external
directory💡 I will likely skip code review since this PR only includes developer-facing change.
Screenshots of the directory structure:
📁
js/src/wcdl
📁
js/src/external-components
Detailed test instructions:
npm run dev
can build frontend code without errorsnpm run lint:js
can passnpm run lint:css
can passnpm run test:js
can passAdditional details:
Over the past three to four years, the component development of the WooCommerce Design Library has stalled in this project for a long time and has become mismatched with the later evolution of the WooCommerce Design Library, so it may not be necessary to keep the original purpose and the
wcdl
directory.See: p1694792606788619-slack-C05BG9S6B96
Changelog entry