Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid errors caused by automatically saving invalid shipping times during onboarding #2706

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Dec 3, 2024

Changes proposed in this Pull Request:

This PR avoids errors caused by automatically saving invalid shipping times during onboarding.

Kapture.2024-12-03.at.12.34.29.mp4

The issue also causes a flaky E2E test case although it can pass on the second retry:

image

Screenshots:

Kapture.2024-12-03.at.12.33.07.mp4

Detailed test instructions:

  1. Go to step 2 of the onboarding flow
  2. Enter a shipping time setup where the min days is greater than its max days
  3. Check if the API error, "There was an error saving shipping times.", doesn't occur
  4. View the E2E tests run on GitHub Actions to see if the flaky E2E test case no longer occur

Changelog entry

@eason9487 eason9487 self-assigned this Dec 3, 2024
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.4%. Comparing base (253012d) to head (2b00666).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ponents/free-listings/setup-free-listings/index.js 0.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2706      +/-   ##
============================================
- Coverage       66.1%   63.4%    -2.7%     
============================================
  Files            479     340     -139     
  Lines          19543    5210   -14333     
  Branches           0    1275    +1275     
============================================
- Hits           12927    3305    -9622     
+ Misses          6616    1730    -4886     
- Partials           0     175     +175     
Flag Coverage Δ
js-unit-tests 63.4% <0.0%> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/free-listings/setup-free-listings/index.js 6.2% <0.0%> (ø)

... and 818 files with indirect coverage changes

@eason9487 eason9487 requested a review from a team December 3, 2024 04:48
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing it. Tested locally and confirmed the invalid shipping times weren't saved automatically.

@eason9487 eason9487 merged commit 155dc31 into develop Dec 3, 2024
10 checks passed
@eason9487 eason9487 deleted the fix/onboarding--save-shipping-times-error branch December 3, 2024 06:02
@puntope puntope mentioned this pull request Dec 3, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants