Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick rebranding tour to the hamburger icon on mobile #2692

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Nov 24, 2024

Changes proposed in this Pull Request:

Set reference element for rebranding tour to main menu hamburger icon on mobile viewports.

Fixes #2680

Replace this with a good description of your changes & reasoning.

Screenshots:

Before

image

After

image

Detailed test instructions:

  1. Checkout and build this branch
  2. Restart the rebranding tour wp.data.dispatch( 'wc/gla' ).upsertTour( { id: 'rebranding-tour', checked: false } )
  3. Open any G4W on a mobile viewport
  4. Check that the tour step is visible and dismissable with x button

Additional details:

Changelog entry

Fix rebranding tour on mobile

@tomalec tomalec requested a review from a team November 24, 2024 18:51
@tomalec tomalec self-assigned this Nov 24, 2024
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.4%. Comparing base (16df5ec) to head (e15ffd0).
Report is 1167 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2692      +/-   ##
============================================
- Coverage       64.9%   62.4%    -2.5%     
============================================
  Files            793     321     -472     
  Lines          24342    5130   -19212     
  Branches        1231    1242      +11     
============================================
- Hits           15790    3201   -12589     
+ Misses          8379    1756    -6623     
  Partials         173     173              
Flag Coverage Δ
js-unit-tests 62.4% <ø> (-0.3%) ⬇️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 481 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@tomalec tomalec merged commit 0d356b7 into develop Nov 25, 2024
9 checks passed
@tomalec tomalec deleted the fix/2680-rebranding-tour-mobile branch November 25, 2024 09:39
@ianlin ianlin mentioned this pull request Nov 26, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Google Listings & Ads is now Google for WooCommerce" banner is cut off on mobile.
2 participants