Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 6.7 Compatibility: Adjust the radio control layout to align well with the extended content #2671

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

The layout of the radio control is a bit displaced.
This PR adjusts it to make it sill align well with the extended content.

💡 WordPress 6.7 has decreased the size of the Radio control a bit. For the sake of consistency of the overall experience, the size is not further adjusted in this plugin.

Screenshots:

📷 WordPress 6.6

Image

📷 WordPress 6.7 without this fix

Image

📷 WordPress 6.7 with this fix

image

Detailed test instructions:

  1. Set up WordPress with 6.7-RC3
  2. Go to the Edit free listings page
  3. Check if the layouts of radio controls and their content are aligned well

Changelog entry

Tweak - WordPress 6.7 Compatibility: Adjust the layout of the radio control to align well with the extended content.

@eason9487 eason9487 requested a review from a team November 11, 2024 11:04
@eason9487 eason9487 self-assigned this Nov 11, 2024
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Nov 11, 2024
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I tested this with WP 6.7-RC4 and can confirm I was seeing the same issue:
image

After the fix the radio controls are back to normal:
image

@eason9487 eason9487 merged commit 0c480a4 into develop Nov 12, 2024
6 checks passed
@eason9487 eason9487 deleted the tweak/compat-wp-6-7-radio-control branch November 12, 2024 05:43
This was referenced Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants