-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2590 consolidate google account cards #2633
Closed
joemcgill
wants to merge
25
commits into
feature/2458-streamline-onboarding
from
feature/2590-consolidate-google-account-cards
Closed
Feature/2590 consolidate google account cards #2633
joemcgill
wants to merge
25
commits into
feature/2458-streamline-onboarding
from
feature/2590-consolidate-google-account-cards
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-and-accounts-cards Removes initial cards as part of refactoring
…onsolidate-google-account-cards
Remove ads and merchant center tests.
…oocommerce/google-listings-and-ads into feature/2566-google-combo-card
Onboarding: Create New Google Combo Accounts Card.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2458-streamline-onboarding #2633 +/- ##
==================================================================
Coverage 62.7% 62.7%
==================================================================
Files 319 319
Lines 5063 5063
Branches 1233 1233
==================================================================
Hits 3173 3173
Misses 1716 1716
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. |
…onsolidate-google-account-cards
Somehow this branch was misnamed, I'm closing this PR and we'll update all the related PRs to use the feature branch feature/2509-consolidate-google-account-cards, which is what this should have been. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2509.
Feature branch including code from the following PRs:
[TK list]
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry