Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accounts onboarding: Automatically preselect a Google Ads account when there is only one, as well as adjust the UI presentation #2608

Fix linter warnings

3b87196
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2024 in 0s

62.7% (-2.5%) compared to 40bbf82

View this Pull Request on Codecov

62.7% (-2.5%) compared to 40bbf82

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (40bbf82) to head (3b87196).
Report is 116 commits behind head on feature/2458-streamline-onboarding.

Files with missing lines Patch % Lines
js/src/components/app-select-control/index.js 80.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/2458-streamline-onboarding   #2608      +/-   ##
=======================================================================
- Coverage                                  65.2%   62.7%    -2.5%     
=======================================================================
  Files                                       800     319     -481     
  Lines                                     22899    5063   -17836     
  Branches                                   1230    1233       +3     
=======================================================================
- Hits                                      14928    3174   -11754     
+ Misses                                     7803    1716    -6087     
- Partials                                    168     173       +5     
Files with missing lines Coverage Δ
...unt-card/connect-ads/ads-account-select-control.js 100.0% <100.0%> (ø)
...components/merchant-center-select-control/index.js 100.0% <ø> (ø)
js/src/components/app-select-control/index.js 85.7% <80.0%> (-14.3%) ⬇️

... and 489 files with indirect coverage changes