Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline campaign setup: Remove ads audience field from paid ads setup during onboarding #2551
Streamline campaign setup: Remove ads audience field from paid ads setup during onboarding #2551
Changes from 4 commits
041a075
2e0d8aa
bac491e
50b13df
31fcd2a
d8b7d40
a782cf0
236aa95
53fdc4b
a66a23e
72b5e76
4bf8bea
5d5ed13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By setting an empty array as the default parameter, it seems targetAudience isn’t required, and we can create ads without specifying any countries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorgemd24 . Happy to revert that change but when I tested the "Continue" button to proceed to the next step was disabled if there were no countries selected. Screenshot below:
Also, in the
validateCampaign
function, there's a check for an empty array of countries.google-listings-and-ads/js/src/components/paid-ads/validateCampaign.js
Line 19 in 93b4180
Let me know what you think 😁