Streamline campaign setup: Show campaign setup fields immediately during onboarding #2533

asvinb · 2024-08-16T13:37:03Z

Changes proposed in this Pull Request:

Closes #2500 .

Show all the setup fields by default.
Removed all associated tests and helper files.

Screenshots:

Detailed test instructions:

Go through the onboarding flow again.
On the fourth step, i.e Create a campaign, the fields to create a campaign should be shown by default.
The "Skip this step for now" and "Create campaign" buttons should not be present.

Additional details:

Changelog entry

Tweak - Show campaign setup fields immediately during onboarding.

codecov · 2024-08-16T13:43:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (5ec87d6) to head (068f4c4).
Report is 12 commits behind head on feature/2459-campaign-creation-flow.

Additional details and impacted files

@@                         Coverage Diff                         @@
##           feature/2459-campaign-creation-flow   #2533   +/-   ##
===================================================================
  Coverage                                 63.8%   63.8%           
===================================================================
  Files                                      326     326           
  Lines                                     5089    5089           
  Branches                                  1232    1232           
===================================================================
  Hits                                      3247    3247           
  Misses                                    1674    1674           
  Partials                                   168     168

Flag	Coverage Δ
js-unit-tests	`63.8% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

joemcgill

@asvinb this is looking pretty good. Left a few suggestions.

joemcgill · 2024-08-16T17:35:08Z

js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js

-			} );
-		}
+		merge( eventProps, {
+			opened_paid_ads_setup: 'yes',


Now that we're removing the possibility of skipping without opening the ads setup, this event prop should be removed from the whole component and removed from the inline docs for gla_onboarding_complete_button_click above.

I think we could also avoid the need to merge event props here and just set them directly when eventProps is initialized above.

Good catch and makes sense @joemcgill . I've updated the PR. Can you kindly take a look again please?

tests/e2e/utils/pages/setup-mc/step-4-complete-campaign.js

tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js

tests/e2e/utils/pages/setup-mc/step-4-complete-campaign.js

joemcgill

Thanks for the updates. Sorry I missed that there were already separate tests for the second "Skip paid ads creation" button, your previous changes look correct.

ankitguptaindia · 2024-08-22T15:24:48Z

QA/Test Report- ✅

Testing Environment -

WordPress: 6.6.1
Theme active on store: Storefront Version: 4.6.0
WooCommerce - Version 9.2.1
PHP: 8.3
Web Server: Nginx
Browser: Chrome - Version 127
OS: macOS Sonoma 14.6.1

Steps to Test- Please follow the steps mentioned in PR description and watch below attached screencast for all screens.

Test Results - Tested the changes in onboarding flow, and all scenarios are functioning as expected.

UI Appearance: The interface displays as expected. ✅
Console Errors: No errors were found in the browser console. ✅
PHP Logs: The logs are clean, with no errors reported. ✅
Onboarding Flow: Merchants can successfully complete the onboarding flow with new changes. ✅
Onboarding Flow Merchants have the option to Skip paid ads creation ✅

Functional Demo / Screencast -

Recording.803.mp4

Next Step- Ready to Code Review(Woo)

Plugin file with this change related code:
google-listings-and-ads.zip

joemcgill · 2024-08-23T14:04:39Z

@eason9487 this one is ready for your review

jorgemd24

Hi @asvinb, I tested this locally, and it’s working well. I just have a question about the event props—previously, the default value was unknown for some of the properties, but now the behavior has changed. Let me know your thoughts. Thanks!

js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js

joemcgill

The updates seem ok to me. @eason9487 can you give it another look?

eason9487

LGTM

joemcgill · 2024-09-09T19:40:31Z

@asvinb can you take a look at the merge conflicts here?

…show-campaign-fields

…merce/google-listings-and-ads into feature/2500-show-campaign-fields

joemcgill · 2024-09-10T18:00:40Z

Tested again after the merge conflicts were adjusted. Merging.

asvinb added 2 commits August 16, 2024 17:09

Show campaign creation fields by default.

8774a7e

Remove associated tests.

0e22ee2

asvinb requested a review from joemcgill August 16, 2024 13:37

joemcgill requested changes Aug 16, 2024

View reviewed changes

asvinb added 2 commits August 20, 2024 13:32

Merge branch 'develop' into feature/2500-show-campaign-fields

cd2fcc3

Remove the opened_paid_ads_setup prop and no need to merge objects.

977d9e1

joemcgill approved these changes Aug 21, 2024

View reviewed changes

joemcgill changed the base branch from develop to feature/2459-campaign-creation-flow August 22, 2024 14:28

ankitguptaindia self-requested a review August 22, 2024 15:25

ankitguptaindia approved these changes Aug 22, 2024

View reviewed changes

joemcgill requested a review from eason9487 August 23, 2024 14:04

eason9487 added the changelog: tweak Small change, that isn't actually very important. label Aug 26, 2024

jorgemd24 reviewed Aug 28, 2024

View reviewed changes

js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js Outdated Show resolved Hide resolved

js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js Outdated Show resolved Hide resolved

Add unknown as fallback value.

a8ac154

eason9487 reviewed Sep 3, 2024

View reviewed changes

js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js Outdated Show resolved Hide resolved

Use logical OR operator.

5284ff6

joemcgill approved these changes Sep 5, 2024

View reviewed changes

eason9487 approved these changes Sep 6, 2024

View reviewed changes

asvinb added 4 commits September 10, 2024 13:14

Merge branch 'feature/2459-campaign-creation-flow' into feature/2500-…

f6b0fd2

…show-campaign-fields

Fix merge conflict.

0d73263

Merge branch 'feature/2500-show-campaign-fields' of github.com:woocom…

10adcf0

…merce/google-listings-and-ads into feature/2500-show-campaign-fields

Revert changes.

068f4c4

joemcgill merged commit 5ac539f into feature/2459-campaign-creation-flow Sep 10, 2024
8 checks passed

joemcgill deleted the feature/2500-show-campaign-fields branch September 10, 2024 18:00

joemcgill mentioned this pull request Sep 26, 2024

Consolidate Ad Creation #2575

Closed

eason9487 changed the title ~~2500: Show paid campaign setup fields during onboarding flow~~ Streamline campaign setup: Show campaign setup fields immediately during onboarding Nov 20, 2024

eason9487 mentioned this pull request Nov 20, 2024

Feature: Streamline the campaign setup #2632

Merged

ianlin mentioned this pull request Nov 26, 2024

Release 2.9.0 #2694

Merged

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Streamline campaign setup: Show campaign setup fields immediately during onboarding #2533

Streamline campaign setup: Show campaign setup fields immediately during onboarding #2533

asvinb commented Aug 16, 2024 •

edited by eason9487

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading

joemcgill left a comment

joemcgill Aug 16, 2024

asvinb Aug 20, 2024

joemcgill left a comment

ankitguptaindia commented Aug 22, 2024 •

edited

Loading

joemcgill commented Aug 23, 2024

jorgemd24 left a comment

joemcgill left a comment

eason9487 left a comment

joemcgill commented Sep 9, 2024

joemcgill commented Sep 10, 2024

Streamline campaign setup: Show campaign setup fields immediately during onboarding #2533

Streamline campaign setup: Show campaign setup fields immediately during onboarding #2533

Conversation

asvinb commented Aug 16, 2024 • edited by eason9487 Loading

Changes proposed in this Pull Request:

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov bot commented Aug 16, 2024 • edited Loading

Codecov Report

joemcgill left a comment

Choose a reason for hiding this comment

joemcgill Aug 16, 2024

Choose a reason for hiding this comment

asvinb Aug 20, 2024

Choose a reason for hiding this comment

joemcgill left a comment

Choose a reason for hiding this comment

ankitguptaindia commented Aug 22, 2024 • edited Loading

QA/Test Report- ✅

joemcgill commented Aug 23, 2024

jorgemd24 left a comment

Choose a reason for hiding this comment

joemcgill left a comment

Choose a reason for hiding this comment

eason9487 left a comment

Choose a reason for hiding this comment

joemcgill commented Sep 9, 2024

joemcgill commented Sep 10, 2024

asvinb commented Aug 16, 2024 •

edited by eason9487

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading

ankitguptaindia commented Aug 22, 2024 •

edited

Loading