Upload coverage report for JS unit tests to codecov #2238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
When running the unit tests for JS, coverage reports are already being generated in various formats. This PR uploads the clover format to codecov.io so they can be included in the coverage report comment.
The coverage comment is currently only showing the status for PHP coverage, since there is no base to compare with yet for the JS coverage reports. Over time we'll have to monitor how accurate this is, since JS / PHP coverage reports are run conditionally depending on which files are changed. So not every PR / head commit has both to compare the differences.
Closes #864
Detailed test instructions:
Changelog entry