Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-1.1] Move useGoogleAccountCheck to its own file #2227

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[R-1.1] Move useGoogleAccountCheck to its own file #2227

merged 1 commit into from
Jan 30, 2024

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Jan 30, 2024 •
edited by eason9487
Loading

Changes proposed in this Pull Request:

Update the useGoogleAccountCheck hook to live in its own file and return additional properties. Remove the line from the original PR where the rule of hooks was disabled within the hook.

Additional details:

Changelog entry

@asvinb asvinb requested a review from joemcgill January 30, 2024 09:53
joemcgill
joemcgill approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought. Thanks, @asvinb!

@joemcgill joemcgill merged commit a4c67fd into feature/setup-google-ads-in-step1 Jan 30, 2024
7 checks passed
@joemcgill joemcgill deleted the feature/setup-google-ads-in-step1-followup branch January 30, 2024 15:18
@eason9487 eason9487 added the changelog: tweak Small change, that isn't actually very important. label Feb 1, 2024
@eason9487 eason9487 added changelog: none Skip changelog entry for this PR and removed changelog: tweak Small change, that isn't actually very important. labels Mar 15, 2024
@eason9487 eason9487 changed the title Move useGoogleAccountCheck to its own file. [R-1.1] Move useGoogleAccountCheck to its own file May 29, 2024
@eason9487 eason9487 mentioned this pull request May 29, 2024
Merged
2 tasks
@mikkamp mikkamp mentioned this pull request Jun 10, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcgill joemcgill joemcgill approved these changes

Assignees

@asvinb asvinb

Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvinb @joemcgill @eason9487