Send the related tracking event with the account ID to be connected when connecting to an existing Google Merchant Center or Google Ads account

[eason9487]

Changes proposed in this Pull Request:

It's a follow-up PR for #2199 (comment).

This PR adds the account ID to be connected to the properties of the gla_mc_account_connect_button_click and gla_ads_account_connect_button_click events.

Screenshots:

📹 Connect Google Merchant Center account

Kapture.2024-01-18.at.11.10.19.mp4

📹 Connect Google Ads account

Kapture.2024-01-18.at.11.05.33.mp4

Detailed test instructions:

1. Enable tracking debug tool
   • Open the Console tab of the browser DevTool.
   • Change the filter level to "All levels".
   • Run localStorage.setItem( 'debug', 'wc-admin:*' ) and refresh the page to make it work.
   • It should be able to view tracking via the Console tab. Ref:
     
2. Disconnect Google Merchant Center and Google Ads accounts if already connected.
3. Go to the first step of onboarding flow.
4. Connect to an existing Google Merchant Center account and check if the gla_mc_account_connect_button_click event properties have the id and if its value is correct.
5. Proceed to the last step of onboarding flow.
6. Connect to an existing Google Ads account and check if the gla_ads_account_connect_button_click event properties have the id and if its value is correct.

Changelog entry

Add - Send the related tracking event with the account ID to be connected when connecting to an existing Google Merchant Center or Google Ads account.

[jorgemd24]

Hi, @eason9487, thanks for this adjustment. I followed the steps that you mentioned in the PR and everything works well, however, I have a doubt before approving this PR, why do we use id as an event property instead of their respective names, for example: gla_ads_id and gla_mc_id ?

[eason9487]

Thanks for the review, @jorgemd24

why do we use id as an event property instead of their respective names, for example: gla_ads_id and gla_mc_id?

The gla_mc_id property is only included when there is a connected Google Merchant Center account, and the same goes for gla_ads_id and Google Ads account.

At the moment the "Connect" button is clicked, the account is not yet connected, so id is used to indicate the account ID to be connected and to distinguish it from gla_mc_id or gla_ads_id.

[jorgemd24]

Thanks @eason9487 for the clarification, so it's just a "way" to distinguish between connected and not connected. I guess we will be able to tell which type of id is (ads or mc) by checking the event name. I am approving the PR as it works as expected and the doubt that I had about the event property name has been clarified.

[eason9487]

so it's just a "way" to distinguish between connected and not connected. I guess we will be able to tell which type of id is (ads or mc) by checking the event name.

Yes, like many other events, they may have the same event property name, but each property's meaning needs to be interpreted along with its event name or somewhat context.