Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.12 #2160

Merged
merged 38 commits into from
Nov 22, 2023
Merged

Release 2.5.12 #2160

merged 38 commits into from
Nov 22, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2023

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.5.12
    git checkout release/2.5.12
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.5.12  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.12
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.5.12   --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.12
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.5.12, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

matt-h and others added 29 commits August 15, 2023 10:52
…ers.

Allows other plugins to be able to extend the capabilities to handle shipping method rates.
Release 2.5.11 - Merge `trunk` to `develop`
…ules-flush

Remove unused flush_rewrite_rules
Add node ^18 and npm ^9 as supported engines for dependabot
Bumps [axios](https://github.com/axios/axios) from 1.4.0 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.4.0...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…el/traverse-7.23.3

Bump @babel/traverse from 7.20.1 to 7.23.3
…wserify-sign-4.2.2

Bump browserify-sign from 4.2.1 to 4.2.2
Add filter to be able to build custom shipping method rate handers.
@jorgemd24 jorgemd24 self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2160 (3cacf04) into trunk (92d15c7) will increase coverage by 0.0%.
Report is 380 commits behind head on trunk.
The diff coverage is 51.8%.

❗ Current head 3cacf04 differs from pull request most recent head 676d649. Consider uploading reports for the commit 676d649 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             trunk   #2160   +/-   ##
=======================================
  Coverage     58.3%   58.3%           
- Complexity    4114    4119    +5     
=======================================
  Files          454     452    -2     
  Lines        17676   17679    +3     
=======================================
+ Hits         10297   10305    +8     
+ Misses        7379    7374    -5     
Flag Coverage Δ
php-unit-tests 58.3% <51.8%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Google/Ads.php 93.8% <ø> (ø)
src/API/Google/AdsAsset.php 95.2% <ø> (ø)
src/API/Google/AdsAssetGroup.php 73.7% <ø> (ø)
src/API/Google/AdsAssetGroupAsset.php 84.8% <100.0%> (ø)
src/API/Google/AdsCampaign.php 97.3% <100.0%> (+0.1%) ⬆️
src/API/Google/AdsCampaignBudget.php 92.7% <ø> (ø)
src/API/Google/AdsCampaignCriterion.php 100.0% <ø> (ø)
src/API/Google/AdsConversionAction.php 97.6% <ø> (ø)
src/API/Google/AdsReport.php 91.3% <ø> (ø)
src/API/Google/AssetFieldType.php 100.0% <ø> (ø)
... and 155 more

... and 13 files with indirect coverage changes

@jorgemd24
Copy link
Contributor

What's Changed

[Add] New Features 🎉

[Fix] Fixes 🛠

[Tweak] Tweaked 🔧

[Dev] Developer-facing changes 🧑‍💻

New Contributors

Full Changelog: 2.5.11...2.5.12

@jorgemd24 jorgemd24 merged commit 319a54b into trunk Nov 22, 2023
@jorgemd24 jorgemd24 deleted the release/2.5.12 branch November 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants