Externalize all @wordpress packages via DEWP
#2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`@wordpress/components`.
…`@wordpress/components`.
…ent imported from `@wordpress/components`.
… a Modal before. Currently, the minimum supported version of this extension is WP 5.9. - This hack doesn't work for WP 5.9 and 6.0. - WP >= 6.1 itself has already fixed this issue, so it's no longer needed.
…nd-card Externalize `Flex`, `Card` and their associated group components imported from `@wordpress/components`
…notice-tip Externalize `Dashicon`, `Icon`, `Notice` and `Tip` components imported from `@wordpress/components`
…ropdown-modal Externalize `NavigableMenu`, `Dropdown` and `Modal` components imported from `@wordpress/components`
…`@wordpress/components`.
…m the external source of DEWP.
eason9487
changed the title
@wordpress packages imports via DEWP@wordpress packages via DEWP
…ation process" This reverts commit 2d0e0d6.
Externalize all `*Control` components imported from `@wordpress/components`
Opt-in all `@wordpress` packages imports via DEWP
|
I generally tested the externalized components in the following combinations and no issues were found.
I will be merging this PR to complete the entire externalization for all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #1833
💡 All code changes have been reviewed and tested in the respective PRs. Therefore, this PR should not require extra rounds of code reviews.
Changelog entry