Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMax Assets: Prevent the button styles in ImagesSelector from overriding by AutomateWoo #1909

Merged
merged 1 commit into from
Feb 28, 2023
Merged

PMax Assets: Prevent the button styles in ImagesSelector from overriding by AutomateWoo #1909

merged 1 commit into from
Feb 28, 2023

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

It's a follow-up and relates to #1787.

In #1873 (review) and #1873 (comment):

I think the delete button looks too big compared with the preview images, what do you think? Or comparing with the Figma file, it seems that the preview images should be bigger.

The conflict with the styling is with AutomateWoo 5.6.6 when I disable AW loads correctly.

This PR fixes the style conflict that results in style problems in the ImagesSelector:

2023-02-28 14 12 17

In the screenshot, the style problems are:

  1. Incorrect image button size.
  2. The border of Image buttons disappears.
  3. The X button should show up when hovering over the image button.
  4. Incorrect background color of X button.

Screenshots:

2023-02-28 14 21 56

Detailed test instructions:

  1. Install and activate AutomateWoo.
  2. Go to step 2 of the campaign creation page.
  3. Select some images to see if the style looks good and is similar to the design in Figma.

Changelog entry

@eason9487 eason9487 requested a review from a team February 28, 2023 07:13
@eason9487 eason9487 self-assigned this Feb 28, 2023
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Feb 28, 2023
puntope
puntope approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Now it looks nicer and matching the Figma

@eason9487 eason9487 merged commit 9201350 into feature/pmax-assets Feb 28, 2023
@eason9487 eason9487 deleted the tweak/1787-avoid-automatewoo-style-conflict branch February 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puntope puntope puntope approved these changes

Assignees

@eason9487 eason9487

Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @puntope