Prevent the "import/no-duplicates" warning for the externalization process #1844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Quotes from @ecgan's #1834 (comment):
This PR changes to use the "no-duplicate-imports" rule to prevent the warnings.
Screenshots:
It can still find the basic duplicated imports:
Detailed test instructions:
npm run lint:js
Additional details:
"no-duplicate-imports" doesn't do the actual file path resolving, so something like
import Foo from '. /foo'
andimport Foo from '. /foo.js'
are not recognized as duplicates.However, such rules are for code clearer purposes only, and these undetected duplicates should not cause errors.
Changelog entry