-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get started page UX improvements: add features card #1440
Merged
ianlin
merged 9 commits into
feature/1392-ux-improvements-on-get-started-page
from
add/1392-features-card
Apr 27, 2022
Merged
Get started page UX improvements: add features card #1440
ianlin
merged 9 commits into
feature/1392-ux-improvements-on-get-started-page
from
add/1392-features-card
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eason9487
reviewed
Apr 25, 2022
As it would be blocked by an external ad-block extension.
Thanks for the review @eason9487, the PR is ready for the next round of the review. |
eason9487
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Tested locally, and it works as expected. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Part of #1392, this PR adds the benefits card to the new get started page.
Design for desktop: eQ9O4m2flzrcAiDMXkOW0m-fi-7350%3A121114
Design for mobile: eQ9O4m2flzrcAiDMXkOW0m-fi-7476%3A122839
Screenshots:
Desktop
Mobile
Detailed test instructions:
https://domain.test/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fstart
Testing for Tracking Events
localStorage.setItem('debug', 'wc-admin*')
.https://domain.test/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fstart
Learn More
, it should open a new tab to https://woocommerce.com/document/google-listings-and-ads/#google-smart-shopping-campaigns. From the dev console you should see an event is sent withlink_id
=get-started-features-free-listing-learn-more
.Learn More
, it should open a new tab to https://woocommerce.com/document/google-listings-and-ads/#google-smart-shopping-campaigns. From the dev console you should see an event is sent withlink_id
=get-started-features-google-ads-learn-more
.Learn More
, it should open a new tab to https://woocommerce.com/document/google-listings-and-ads/#getting-started-with-campaign-analytics. From the dev console you should see an event is sent withlink_id
=get-started-features-dashboard-learn-more
.Changelog entry