Merge pull request #2260 from woocommerce/fix/1959-prevent-find-by-id…

…s-executing-without-ids-supplied

Prevent find_by_ids executing if no arguments are supplied

src/Product/ProductRepository.php

@@ -88,6 +88,11 @@ public function find_ids( array $args = [], int $limit = -1, int $offset = 0 ):
 	 * @return WC_Product[] Array of WooCommerce product objects
 	 */
 	public function find_by_ids( array $ids, array $args = [], int $limit = -1, int $offset = 0 ): array {
+		// If no product IDs are supplied then return early to avoid querying and loading every product.
+		if ( empty( $ids ) ) {
+			return [];
+		}
+
 		$args['include'] = $ids;
 
 		return $this->find( $args, $limit, $offset );

tests/Unit/Product/ProductRepositoryTest.php

@@ -144,6 +144,8 @@ public function test_find_by_ids() {
 			array_map( 'wc_get_product', $ids ),
 			$this->product_repository->find_by_ids( $ids )
 		);
+
+		$this->assertEquals( [], $this->product_repository->find_by_ids( [] ) );
 	}
 
 	public function test_find_synced_products() {