fix(scan): use correct CPE for GitLab components #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
cpanato
reviewed
Oct 7, 2024
cpanato
previously approved these changes
Oct 7, 2024
|
If we're only ever using the "community" version of GitLab source, we could consider updating the CPE to Here's an updated look on scan results if we do this: $ wolfictl scan -D ./gitlab-base-17.1-17.1.2-r10.apk
🔎 Scanning "./gitlab-base-17.1-17.1.2-r10.apk"
└── 📄 /.PKGINFO
📦 gitlab-base-17.1 17.1.2-r10 (apk)
Low CVE-2024-0231
High CVE-2024-3035
Medium CVE-2024-3114
Medium CVE-2024-3958
Medium CVE-2024-4207
Medium CVE-2024-4210
Medium CVE-2024-4472
Critical CVE-2024-45409
Medium CVE-2024-5423
Medium CVE-2024-5435
High CVE-2024-6329
Medium CVE-2024-6389
Low CVE-2024-6446
Medium CVE-2024-6502
High CVE-2024-6678
Medium CVE-2024-6685
Medium CVE-2024-7047
Medium CVE-2024-7057
Medium CVE-2024-7060
Medium CVE-2024-7091
Medium CVE-2024-7554
Medium CVE-2024-7610
Medium CVE-2024-8041
High CVE-2024-8124
High CVE-2024-8641
High CVE-2024-8754
Medium CVE-2024-8974 |
Signed-off-by: Dan Luhring <[email protected]>
cpanato
approved these changes
Oct 7, 2024
|
This gives us another good reason to validate Syft/Grype results in comparison to what other tools return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been missing CVEs in GitLab. For NVD data, GitLab has a CPE of:
cpe:2.3:a:gitlab:gitlab:*:*:*:*:*:*:*:*.Syft has been generating lots of CPEs for GitLab components, but they're never correct. For example:
{ "cpe": "cpe:2.3:a:gitlab_logger:gitlab-logger:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }, { "cpe": "cpe:2.3:a:gitlab_logger:gitlab_logger:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }, { "cpe": "cpe:2.3:a:gitlab:gitlab-logger-17.4:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }, { "cpe": "cpe:2.3:a:gitlab:gitlab_logger_17.4:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }, { "cpe": "cpe:2.3:a:gitlab:gitlab-logger:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }, { "cpe": "cpe:2.3:a:gitlab:gitlab_logger:17.4.0-r2:*:*:*:*:*:*:*", "source": "syft-generated" }This PR sets the GitLab CPE explicitly when the APK package name is prefixed by
gitlab-.For reference, here are the packages (including subpackage) currently defined in Wolfi with that prefix:
Impact on scanning
Here's an example using an enterprise package:
Before
After