-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 3.2.62 version with newrelic-infrastructure-bundle package #38577
Conversation
Gen AI suggestions to solve the build error: Based on the error log and the melange YAML file, I'll analyze and provide a solution: • Detected Error: The build is failing during Git checkout stage, though the specific error isn't shown in the logs • Error Category: Version/Commit • Failure Point: git-checkout pipeline step • Root Cause Analysis: The expected commit hash (9885fc554171f891869b1a30e09789ef2f63ffb2) likely doesn't match the commit at tag v3.2.63, causing the checkout to fail • Suggested Fix:
- uses: git-checkout
with:
repository: https://github.com/newrelic/infrastructure-bundle
tag: v${{package.version}}
# Remove or update expected-commit field
destination: ${{package.name}} • Explanation:
• Additional Notes:
• References:
|
I think upstream deleted one of the tags/releases because the package we've for now is 3.2.63 but that doesn't exist anymore upstream. https://github.com/newrelic/infrastructure-bundle/tags If we go back to 3.2.62 then we'll need to withdraw 3.2.63 version so that |
looking more, I think I would like to remove this version and bump the epoch for the |
use 3.2.62 version and bump the epoch this is being done because 3.2.63 version doesn't exist upstream. newrelic-infrastructure-bundle-3.2.62-r0.apk is the apk that exists in there's another PR to remove 3.2.63 version from wolfi Signed-off-by: kranurag7 [email protected] |
Gen AI suggestions to solve the build error: Based on the error output and the Melange YAML file, I'll analyze and provide specific fixes. • Detected Error: No explicit error message, but the build appears to stop after dependency installation without completing the package build • Error Category: Configuration • Failure Point: After dependency installation, before package assembly • Root Cause Analysis: The pipeline section is essentially empty except for git-checkout and strip. There's no actual build or package assembly steps defined. The strip step is marked as "NO-OP" in comments. • Suggested Fix: pipeline:
- uses: git-checkout
with:
repository: https://github.com/newrelic/infrastructure-bundle
tag: v${{package.version}}
expected-commit: 9885fc554171f891869b1a30e09789ef2f63ffb2
destination: ${{package.name}}
- uses: mkdir
with:
path: /empty
- uses: virtual-package • Explanation:
• Additional Notes:
• References:
|
Signed-off-by: wolfi-bot <[email protected]>
this is being done because 3.2.63 version doesn't exist upstream. newrelic-infrastructure-bundle-3.2.62-r0.apk is the apk that exists in wolfi as of now for 3.2.62 version. So bumping the epoch to 1 and setting the version to 3.2.62 works here. there's another PR to remove 3.2.63 version from wolfi #38749 Signed-off-by: kranurag7 <[email protected]>
d7b2b09
to
9f5a8a3
Compare
Gen AI suggestions to solve the build error: Based on the error output and the melange YAML file, I'll analyze and provide specific fixes: • Detected Error: No explicit error message, but the build stops after setting up the build environment. This indicates the pipeline is failing silently after the git-checkout step. • Error Category: Configuration • Failure Point: After git-checkout step, before the strip step • Root Cause Analysis: The melange file is attempting to build a bundle package but doesn't actually perform any meaningful build steps. The strip step is marked as NO-OP and there's no actual package assembly happening. • Suggested Fix: pipeline:
- uses: git-checkout
with:
repository: https://github.com/newrelic/infrastructure-bundle
tag: v${{package.version}}
expected-commit: 9885fc554171f891869b1a30e09789ef2f63ffb2
destination: ${{package.name}}
- uses: mkdir
with:
path: ${{targets.destdir}}/usr/bin
# Create empty package to satisfy dependencies
- runs: |
touch ${{targets.destdir}}/.keep • Explanation:
• Additional Notes:
• References:
|
Signed-off-by: kranurag7 <[email protected]>
once this is merged we can merge #38749 and run this https://github.com/wolfi-dev/os/actions/workflows/withdraw-packages.yaml workflow from main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun one. Thank-you for handling this, agree on the approach
Upstream removed v3.2.63 tag. Separate PR to clean up: #38749