Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-mistune/3.1.0 package update #38496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 30, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. auto-approver-bot/initial-checks-failed labels Dec 30, 2024
@kranurag7
Copy link
Member

Notes:

this package is breaking at tests level, the build is passing.
the reason it's breaking is because mistune requires typing_extensions as runtime dependency but the interesting part is that this package is only required for python versions < 3.11 which means in our case this is only required for python 3.10.

(hacky_0dTA1M) ~/t/hacky_0dTA1M $ uv pip install mistune --verbose --python-version=3.10
DEBUG uv 0.5.13 (c456bae5e 2024-12-27)
DEBUG Searching for default Python interpreter in virtual environments
DEBUG Found `cpython-3.12.8-linux-x86_64-gnu` at `/home/user/tmp/hacky_0dTA1M/.venv/bin/python3` (active virtual environment)
DEBUG Using Python 3.12.8 environment at: .venv
DEBUG Acquired lock for `.venv`
DEBUG Requirement satisfied: mistune
DEBUG Requirement satisfied: typing-extensions ; python_full_version < '3.11'
Audited 1 package in 0.77ms
DEBUG Released lock at `/home/user/tmp/hacky_0dTA1M/.venv/.lock`
(hacky_0dTA1M) ~/t/hacky_0dTA1M $ uv pip install mistune --verbose --python-version=3.11
DEBUG uv 0.5.13 (c456bae5e 2024-12-27)
DEBUG Searching for default Python interpreter in virtual environments
DEBUG Found `cpython-3.12.8-linux-x86_64-gnu` at `/home/user/tmp/hacky_0dTA1M/.venv/bin/python3` (active virtual environment)
DEBUG Using Python 3.12.8 environment at: .venv
DEBUG Acquired lock for `.venv`
DEBUG Requirement satisfied: mistune
Audited 1 package in 0.66ms
DEBUG Released lock at `/home/user/tmp/hacky_0dTA1M/.venv/.lock`
(hacky_0dTA1M) ~/t/hacky_0dTA1M $ uv pip install mistune --verbose --python-version=3.12
DEBUG uv 0.5.13 (c456bae5e 2024-12-27)
DEBUG Searching for default Python interpreter in virtual environments
DEBUG Found `cpython-3.12.8-linux-x86_64-gnu` at `/home/user/tmp/hacky_0dTA1M/.venv/bin/python3` (active virtual environment)
DEBUG Using Python 3.12.8 environment at: .venv
DEBUG Acquired lock for `.venv`
DEBUG Requirement satisfied: mistune
Audited 1 package in 0.61ms
DEBUG Released lock at `/home/user/tmp/hacky_0dTA1M/.venv/.lock`

The fix is following:

  • remove the support of python 3.10 from this package and all the packages that's adding mistune either as runtime or build time dependency (as of now, py3-nbconvert https://github.com/wolfi-dev/os/blob/main/py3-nbconvert.yaml is adding this as runtime dependencies which needs to be updated)
  • we add py${{range.key}}-typing-extensions as runtime dependencies (this will fix it but will be wrong because this is no longer required for versions > 3.11)

I wanted to discuss more on which solution is preferred in cases like this before adding a new commit to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approver-bot/initial-checks-failed automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants