Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 as a dep so g-ir-scanner can run #37370

Closed
wants to merge 1 commit into from

Conversation

murraybd
Copy link
Member

g-ir-scanner would previously fail to run because python3 was not available.

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 17, 2024
Copy link
Member

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. We need to fix the shbang so it uses the Python that it was installed for.

A python3 drop will Get you a /usr/bbin/python3, but not necessarily the right python3.

See my issue for unversioned Python and 313. Also related here is the python-as wrapper, it works likely fix this.

@dannf
Copy link
Member

dannf commented Dec 18, 2024

For reference, here's the issue @smoser is referring to - #37197
According to that, I think we want to try to use the suggestion in the "pick a specific version" example, and then fallback to the python-as-wrapper thing if it fails to inherit a python3.13 shbang.

@smoser
Copy link
Member

smoser commented Dec 18, 2024

For reference, here's the issue @smoser is referring to - #37197

According to that, I think we want to try to use the suggestion in the "pick a specific version" example, and then fallback to the python-as-wrapper thing if it fails to inherit a python3.13 shbang.

If we land Python-as-wrapper (#36891) we can use that. I do think it's useful to generally "do the right thing".

@murraybd
Copy link
Member Author

I'm going to close this in favor of sil2100's PR at #37393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants