Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opensearch-k8s-operator package #31311

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

jspeed-meyers
Copy link
Contributor

@jspeed-meyers jspeed-meyers commented Oct 21, 2024

Please, sir, I would like to add opensearch-k8s-operator package.

There is no explicit project support policy. There is, implicitly, only one supported version. See https://github.com/opensearch-project/opensearch-k8s-operator.

Pre-review Checklist

  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

Signed-off-by: John Speed Meyers <[email protected]>
@jspeed-meyers
Copy link
Contributor Author

I am working on remediating the CVEs. CVE scan below:

jsmeyers:~/work/os$ wolfictl scan packages/x86_64/opensearch-k8s-operator-2.6.1-r0.apk 
🔎 Scanning "packages/x86_64/opensearch-k8s-operator-2.6.1-r0.apk"
└── 📄 /usr/bin/manager
        📦 golang.org/x/net v0.13.0 (go-module)
            High CVE-2023-39325 GHSA-4374-p667-p6c8 fixed in 0.17.0
            Medium CVE-2023-45288 GHSA-4v7x-pqxf-cx7m fixed in 0.23.0
            Medium CVE-2023-44487 GHSA-qppj-fm5r-hxr3 fixed in 0.17.0
        📦 google.golang.org/protobuf v1.30.0 (go-module)
            Medium CVE-2024-24786 GHSA-8r3f-844c-mc37 fixed in 1.33.0

Signed-off-by: John Speed Meyers <[email protected]>
Merge branch 'main' into add-opensearch-k8s-operator
Signed-off-by: John Speed Meyers <[email protected]>
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!! some small comments inline.

opensearch-k8s-operator.yaml Outdated Show resolved Hide resolved
opensearch-k8s-operator.yaml Outdated Show resolved Hide resolved
opensearch-k8s-operator.yaml Outdated Show resolved Hide resolved
@jspeed-meyers
Copy link
Contributor Author

@kranurag7: thank you! I will work on some new commits now. THANK YOU!

Signed-off-by: John Speed Meyers <[email protected]>
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are at this, we will also need a compat package for this looking at upstream deployment.

https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/charts/opensearch-operator/templates/opensearch-operator-controller-manager-deployment.yaml#L57-L58

You can create a compat package something like this.

subpackages:
  - name: ${{package.name}}-compat
    pipeline:
      - runs: |
          mkdir -p ${{targets.contextdir}}
          ln -sf /usr/bin/manager ${{targets.contextdir}}/manager

There will be various examples for creating compat packages in our existing packages if you want to deep dive.

opensearch-k8s-operator.yaml Outdated Show resolved Hide resolved
@jspeed-meyers
Copy link
Contributor Author

jspeed-meyers commented Oct 21, 2024

I added a compat sub-package. Thank you, @kranurag7, for the tutoring and mentorship. I really appreciate this!

@kranurag7 kranurag7 changed the title [WIP] Add opensearch-k8s-operator package Add opensearch-k8s-operator package Oct 21, 2024
@kranurag7 kranurag7 merged commit 4df5dbc into wolfi-dev:main Oct 21, 2024
11 checks passed
@jspeed-meyers jspeed-meyers deleted the add-opensearch-k8s-operator branch October 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants