-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php-8.3: enable provides #10484
php-8.3: enable provides #10484
Conversation
provides: | ||
- php=${{package.full-version}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure downstream packages won't be broken by this? Do we need to do any rebuilds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently there are no packages depending on php-8.3 yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Ville says below. It doesn't matter if they are depending on php-8.3
, if they depend on php
this will mean they get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattmoor the only package using php
virtual is composer , and I checked the official composer docker image it seems to be bundled with 8.3.1
composer:lts "-vvv about"
Failed to initialize global composer: Composer could not find the config file: /tmp/composer.json
To initialize a project, please create a composer.json file. See https://getcomposer.org/basic-usage
Running 2.2.22 (2023-09-29 10:53:45) with PHP 8.3.1 on Linux / 6.5.11-linuxkit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving this to draft for now
So, this will mean that anybody asking for php will get it, is that something that we want to do right now, or put another way, will it break something? |
Pull request was converted to draft
No description provided.