Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-8.3: enable provides #10484

Closed
wants to merge 3 commits into from
Closed

php-8.3: enable provides #10484

wants to merge 3 commits into from

Conversation

ajayk
Copy link
Member

@ajayk ajayk commented Dec 28, 2023

No description provided.

@ajayk ajayk requested a review from vaikas December 28, 2023 23:55
@ajayk ajayk enabled auto-merge December 28, 2023 23:55
Comment on lines +9 to +10
provides:
- php=${{package.full-version}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure downstream packages won't be broken by this? Do we need to do any rebuilds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently there are no packages depending on php-8.3 yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Ville says below. It doesn't matter if they are depending on php-8.3, if they depend on php this will mean they get it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattmoor the only package using php virtual is composer , and I checked the official composer docker image it seems to be bundled with 8.3.1

  composer:lts "-vvv about"
Failed to initialize global composer: Composer could not find the config file: /tmp/composer.json
To initialize a project, please create a composer.json file. See https://getcomposer.org/basic-usage
Running 2.2.22 (2023-09-29 10:53:45) with PHP 8.3.1 on Linux / 6.5.11-linuxkit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving this to draft for now

@vaikas
Copy link
Member

vaikas commented Dec 29, 2023

So, this will mean that anybody asking for php will get it, is that something that we want to do right now, or put another way, will it break something?
Also, There are other provides in this file (config, other subpackages) that will also need to be uncommented for consistency. I sure hope I remembered to label them all 🤔

@ajayk ajayk marked this pull request as draft December 29, 2023 18:06
auto-merge was automatically disabled December 29, 2023 18:06

Pull request was converted to draft

@rawlingsj rawlingsj added the blocked indicates there are blocking issues that need to be addressed before progress can be made label Jan 8, 2024
@ajayk ajayk closed this Feb 1, 2024
@ajayk ajayk deleted the php83 branch February 1, 2024 05:14
@ajayk ajayk mentioned this pull request Apr 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked indicates there are blocking issues that need to be addressed before progress can be made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants