-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special character in file name (subtitles) #74
Comments
@liloneum Thanks, noted - shall be fixed. |
As for special characters in filenames in general. I put some notes here: https://dcpomatic.com/mantis/view.php?id=2465 Repeating below: The Interop (UDF) constraints are a bit messy, I think it would be easier to just enforce the SMPTE rules also for interop. Mainly:
References:SMPTE:ST 429-9:2014 7.1 PathThe Path element indicates the complete path for the Chunk, represented as a URI per [RFC 3986]. Its semantics and format are delivery-medium dependent, and constrained by each Map Profile (see Section 9). The value is encoded as an xs:anyURI. Annex A Basic Map Profile v2 (Normative)A.2 PathEach Path element value shall be a relative-path reference as specified in RFC 3986. No query or fragment component shall be present. INTEROP:https://interop-docs.cinepedia.com/Document_Release_2.0/mpeg_ii_am_spec.pdf 6.4 Chunk Path FormatThe path and filename shall conform to the UDF specification. http://www.osta.org/specs/pdf/udf201.pdfBasic Restrictions & RequirementsFile Name Length: Maximum of 255 bytes 4.2.2.1 char FileIdentifier... |
@matmat thanks for the notes and reminders! Added checks for outsider chars in AM asset paths. Depending on AM type (SMPTE/Interop) the return will be Also added a length check for AM asset paths that should have been in there 10 years ago -_- |
Looks good, thank you! In practice I think lots of DCPs will fail this but still play back without probles (in most cases).. But that's how it is I guess. The festival is coming up and I will battle test this in the coming weeks! :) If/when you have time these additional checks would be nice to have (but some of them maybe unneccecary..):
|
A special character in a subtitle name (ç in my case) will cause a fatal error of ingest with Doremi servers without mentioning the error.
The text was updated successfully, but these errors were encountered: