Fix missing heap hint in RNG health test XMALLOC call #8326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
requested changes
Jan 10, 2025
| @@ -2184,7 +2184,7 @@ static int wc_RNG_HealthTestLocal(int reseed, void* heap, int devId) | |||
| #endif | |||
|
|
|||
| #ifdef WOLFSSL_SMALL_STACK | |||
| check = (byte*)XMALLOC(RNG_HEALTH_TEST_CHECK_SIZE, NULL, | |||
| check = (byte*)XMALLOC(RNG_HEALTH_TEST_CHECK_SIZE, heap, | |||
There was a problem hiding this comment.
As an FYI WOLFSSL_SMALL_STACK builds have a lot of NULL heap hints throughout the library. For this pull request, with adding in the heap hint here, please also add it to the XFREE call at the end of the function around line 2307 and any other location that 'check' is free'd.
Pass provided heap hint to XMALLOC instead of NULL in RNG health test function to ensure proper memory allocation with custom heap.
gasbytes
force-pushed
the
patch-rng-health-test-heap-hint
branch
from
fb7899b to
d491e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass provided heap hint to XMALLOC instead of NULL in RNG health test function to ensure proper memory allocation with custom heap.
Reported by zd#19102.