20241116-fixes #8195
Merged
20241116-fixes #8195
+994
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wolfio.c: #include <errno.h> if necessary; wolfcrypt/src/asn.c: gate WOLFSSL_MSG_EX() uses on defined(DEBUG_WOLFSSL), for pedantic C89 compatibility (no variadic macros); wolfssl/wolfcrypt/wc_port.h: refine setup for XFENCE().
dgarske
approved these changes
Nov 17, 2024
This was referenced Nov 17, 2024
redbaron
reviewed
Nov 18, 2024
| * wolfIO_TcpConnect() even if defined(WOLFSSL_NO_SOCK), which inhibits | ||
| * inclusion of errno.h by wolfio.h. | ||
| */ | ||
| #include <errno.h> |
There was a problem hiding this comment.
just for my understanding, why check for HAVE_ERRNO_H alone is not enough? what is the downside of including it every time it is includable?
There was a problem hiding this comment.
Was just narrowing the fix to avoid having to think about collateral damage on other targets/configs. Chances are it would have been harmless to include errno.h whenever defined(HAVE_ERRNO_H).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
.wolfssl_known_macro_extras;src/wolfio.c:#include <errno.h>if necessary;wolfcrypt/src/asn.c: gateWOLFSSL_MSG_EX()uses ondefined(DEBUG_WOLFSSL), for pedantic C89 compatibility (no variadic macros);wolfssl/wolfcrypt/wc_port.h: refine setup forXFENCE().supersedes #8157 and #8163
tested with
wolfssl-multi-test.sh ... super-quick-checkNote that
.wolfssl_known_macro_extrasis used by a new subtest inwolfssl-multi-test.sh ... check-source-textthat checks for misspelled macros. The file contains only those macros that are not#defined or#undefed anywhere else in the repo, but are used in macro expressions at least once.