Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some dependencies - fixes some vulnerabilities #231

Merged
merged 31 commits into from
Nov 28, 2019
Merged

Conversation

darqs
Copy link
Collaborator

@darqs darqs commented Jul 17, 2019

After all updates npm audit found only 3 vulnerabilities - all in mocha pachage. I try update it also, but I need rewrite some tests first.

I want also update default electron version to latest (5.x).

@darqs darqs changed the title [WIP] Update some dependencies - fixes some vulnerabilities Update some dependencies - fixes some vulnerabilities Jul 17, 2019
darqs added 2 commits July 17, 2019 18:17
electron-5: Added support for Electron 5
Allow config header Access-Control-Allow-Origin on LocalServer module
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #231 into master will increase coverage by 0.77%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   58.63%   59.41%   +0.77%     
==========================================
  Files          20       20              
  Lines        1494     1498       +4     
==========================================
+ Hits          876      890      +14     
+ Misses        618      608      -10
Impacted Files Coverage Δ
skeleton/app.js 5.32% <0%> (-0.43%) ⬇️
skeleton/modules/localServer.js 89.84% <100%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f21b...2e390a1. Read the comment docs.

package.json Outdated Show resolved Hide resolved
lib/electronBuilder.js Outdated Show resolved Hide resolved
@darqs darqs requested a review from wojtkowiak July 28, 2019 12:35
@darqs
Copy link
Collaborator Author

darqs commented Jul 28, 2019

@KoenLav @cbh6
Hello,
can you check this changes (code review and test in your projects will be great)?

@KoenLav
Copy link
Contributor

KoenLav commented Aug 8, 2019

@darqs I combined all changes and released a fork:

https://www.npmjs.com/package/meteor-desktop-test

We're testing this now, but first results look promising.

@darqs
Copy link
Collaborator Author

darqs commented Aug 8, 2019

@KoenLav
Ok, nice. We need some time to test all things, and after it @wojtkowiak can merge it.

@wojtkowiak wojtkowiak merged commit d106a83 into master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants