-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial support for multi architecture builds #65
feat: add initial support for multi architecture builds #65
Conversation
Signed-off-by: Florian Buchmeier <[email protected]>
…u.incrementBy Merge in OSSC/woehrl01-pod-pacemaker from fix/issue-35 to main * commit 'f093131602e7b2cf36a425f3dfef88b4ab172352': docs: fix value range for cpu.maxLoad and cpu.incrementBy
Build Log
|
|
You are right, let me check that. My guess is that the warning is triggered because I am building an arm64 image and then importing (loading) it into an amd64 docker daemon. The binaries themselves look good to me, but I have yet to test them out on arm64 instances:
I'll see if I can switch to my new images (multi-arch) in my test environment. Will get back to you in an hour or so. |
I've successfully rolled out the ARM64 build on AWS Graviton (t4g) instances. For the build to succeed reproducibly I had to make some changes to the Dockerfile as well. I'll update my PR accordingly in a few minutes. pod logs
node labels
UPDATE: I've updated the dockerfile & makefile accordingly and builds now work fast and stable for me (on amd64). |
Signed-off-by: Florian Buchmeier <[email protected]>
…ehrl01-pod-pacemaker into feat/issue-64-arm64-v8
Looks great! Thank you! |
Features
docker buildx
Known Issues
-amd64
and-arm64
tag to load it into kind (see Building images for multi-arch with --load parameter fails docker/buildx#59)build
andpush
can not be cleanly separated and the images need to be built twice, which should not be too much of an issue with proper caching (see Can you split up the build and push steps? docker/buildx#1152 and Building images for multi-arch with --load parameter fails docker/buildx#59 (comment)