Add new ERMicrosoftPlugIn supporting PK generation from sequences #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hprange
force-pushed
the
feature/sql-server-generate-pk-from-sequence
branch
from
a08b4ea to
7d11b5d
Compare
Improves the support for SQL Server with WebObjects. The `ERMicrosoftPlugIn` generates primary keys from sequences instead of the `EO_PK_TABLE` strategy used by the standard `MicrosoftPlugIn`.
The original implementation of the `MicrosoftPlugIn forcibly adds the `SelectMethod=cursor` parameter to the connection URL. Even though this option may be useful in some scenarios, it may also cause undesirable side effects. Each application may have different requirements regarding how and when to use adaptive buffering. For this reason, the `ERMicrosoftPlugin` lets the user decide how to configure adaptive buffering if needed. See the Microsoft documentation for more information about [adaptive buffering](https://docs.microsoft.com/en-us/sql/connect/jdbc/using-adaptive-buffering).
hprange
force-pushed
the
feature/sql-server-generate-pk-from-sequence
branch
from
7d11b5d to
2db1d55
Compare
hprange
changed the title
|
I've been using this plug-in for development for a while and haven't found any issues. Since this plug-in is not enabled by default, I'm willing to merge this pull request. I'm working on other improvements to this plug-in, but they deserve a separate pull request. Any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the support for SQL Server with WebObjects. The
ERMicrosoftPlugIngenerates primary keys from sequences instead of theEO_PK_TABLEstrategy used by the standardMicrosoftPlugIn.Also, the original implementation of the
MicrosoftPlugInforcibly adds theSelectMethod=cursorparameter to the connection URL. Even though this option may be useful in some scenarios, it may also cause undesirable side effects. Each application may have different requirements regarding how and when to use adaptive buffering. For this reason, theERMicrosoftPluginlets the user decide how to configure adaptive buffering if needed.See the Microsoft documentation for more information about adaptive buffering.