Bugfix for ERXSortOrder introduced by commit 65a54 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ordering and NSArray<EOSortOrdering> as well.
…ray<EOSortOrdering> to be synonyms for the prefix() methods. This overloading of #dot() makes prefixing existing EOQualifiers, EOSortOrdering and ERXSortOrderings much more intuitive. For example, let's say Company has a complex array of EOSortOrderings that takes into account things like outstanding invoice amounts, days past due, etc that is expressed in a static field called Company.FINANCIAL_SORT. With the dot() method you could easily create a new array of EOSortOrderings for the Invoice entity by simply writing: Invoice.COMPANY.dot(Company.FINANCIAL_SORT).then(Invoice.DUE_DATE). This allows each Entity to know about it's own EOSortOrderings and you don't have to have EOSortOrderings duplicated in every class (or component) that needs to do a sort.
…ings to the array, and on top of that it doesn't really work to update a mutable array that is then just regenerated without the changes.
|
Forget this, creating a new branch with just the bug fix. Will create a new pull request from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for 65a54e2. Also includes original code.