Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtualenv setuptools #549

Merged
merged 5 commits into from
Dec 28, 2021
Merged

Fix virtualenv setuptools #549

merged 5 commits into from
Dec 28, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

@FollowTheProcess FollowTheProcess commented Dec 28, 2021 •
edited
Loading

Related to discussion in #547.

Related explanation: pre-commit/pre-commit#2178 (comment)

Turns out a better solution to pinning virtualenv is enforcing the stdlib setuptools in CI through an environment variable, which this PR implements

@FollowTheProcess FollowTheProcess mentioned this pull request Dec 28, 2021
Merged
DiddiLeija
DiddiLeija approved these changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FollowTheProcess!

DiddiLeija
DiddiLeija approved these changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, testing on a local branch and a clean venv, this works!

@FollowTheProcess FollowTheProcess merged commit e42f542 into wntrblm:main Dec 28, 2021
@FollowTheProcess
Copy link
Collaborator Author

Thanks all for the help 🎉

@FollowTheProcess FollowTheProcess deleted the fix-virtualenv-setuptools branch December 28, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat left review comments

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FollowTheProcess @gaborbernat @DiddiLeija