Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

fix: css-module support about 'keyframes logo-spin' #416

Open
wants to merge 2 commits into
base: wm-react-scripts-2.x
Choose a base branch
from
Open

fix: css-module support about 'keyframes logo-spin' #416

wants to merge 2 commits into from

Conversation

xiaoxiangmoe
Copy link

  1. fix error about @keyframes logo-spin
  2. In order to maintain the same behavior as the create-react-app, we need use App.module.css rather than using App.css to enable css-module
  3. add *.module.css type definition

vitkon
vitkon reviewed Oct 19, 2018
View reviewed changes
template/images.d.ts Outdated
declare module '*.module.sass' {
const exports: { [exportName: string]: string };
export = exports;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it still reside in images.d.ts? Should it be styles.d.ts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitkon vitkon vitkon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiangmoe @vitkon