fix for issue 658 #659
Merged
fix for issue 658 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Once this PR is merged, we need to keep #658 open given the workaround is due to an issue in code.wmo.int (and we should not be copying the required codelists as a rule).
wis2box-management/Dockerfile
Outdated
| @@ -70,6 +68,8 @@ RUN cd /app \ | |||
| # add wis2box user | |||
| && useradd -ms /bin/bash wis2box | |||
|
|
|||
| RUN pip3 install https://github.com/david-i-berry/wis2box-migrations/archive/main.zip | |||
There was a problem hiding this comment.
Are migrations not part of wis2box proper?
There was a problem hiding this comment.
no, this is an accidental commit, removing
remove old/accidental commit referencing dave's migrations-package
tomkralidis
approved these changes
Apr 23, 2024
tomkralidis
added a commit
that referenced
this pull request
Apr 29, 2024
This reverts commit 9a4e0fc.
maaikelimper
pushed a commit
that referenced
this pull request
Apr 29, 2024
tomkralidis
added a commit
that referenced
this pull request
Jun 27, 2024
This reverts commit 7b4ed20.
maaikelimper
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/workaround for #658