Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change origin/# to origin/a/wis2/# #118

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

maaikelimper
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also make changes to:

  • environment/local-repo-vm-222/subscribe_all.py
  • environment/instructor/live.html

@maaikelimper
Copy link
Collaborator Author

maaikelimper commented Oct 18, 2024

The "environment"-folder was a bit of mess of half-working code, we have some old code to clean up and review

Regarding:

  • environment/local-repo-vm-222/subscribe_all.py
  • environment/instructor/live.html

environment/instructor/live.html refers to what was hacked together during Jakarta. While it is nice to have the map, I think the Fiji training where we just had fake GB + fake GDC without a map worked fine.

I believe environment/local-repo-vm-222/subscribe_all.py was my initial script to check all student-brokers were up.

This functionality is now provided by fake-global-broker-and-cache/subscribe_and_republish.py.

I have created a separate PR to address this:
#123

@tomkralidis tomkralidis merged commit 68e483e into main Oct 18, 2024
1 check passed
@tomkralidis tomkralidis deleted the maaikelimper-patch-1 branch October 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants