Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename resource-type.csv #54

Closed
tomkralidis opened this issue Sep 13, 2023 · 2 comments · Fixed by #56
Closed

rename resource-type.csv #54

tomkralidis opened this issue Sep 13, 2023 · 2 comments · Fixed by #56
Assignees
@tomkralidis
Milestone
INFCOM-3

Comments

@tomkralidis
Copy link
Collaborator

As discussed at TT-WISMD 2023-09-13, rename https://github.com/wmo-im/wis2-topic-hierarchy/blob/main/topic-hierarchy/resource-type.csv to https://github.com/wmo-im/wis2-topic-hierarchy/blob/main/topic-hierarchy/notification-type.csv given the clash of the "resource-type" concept with WCMP2 codelists. This is a working level change to the inner workings of the CSV files here on GitHub.

Thinking more, I'm thinking we should rename to simply type.csv. Thoughts?

cc @gaubert @jsieland @antje-s @josusky @solson-nws @Amienshxq @McDonald-Ian @amilan17 @david-i-berry
@tomkralidis tomkralidis added this to the INFCOM-3 milestone Sep 13, 2023
@tomkralidis tomkralidis changed the title rename resource-type to notification-type rename resource-type.csv Sep 13, 2023
@tomkralidis tomkralidis self-assigned this Sep 25, 2023
@tomkralidis
Copy link
Collaborator Author

TT-WISMD 2023-09-25

  • keep to notification-type to be more specific

tomkralidis added a commit that referenced this issue Sep 25, 2023
@tomkralidis
Update and rename resource-type.csv to notification-type.csv (#54)
7425f5a
tomkralidis added a commit that referenced this issue Sep 25, 2023
@tomkralidis
Update and rename resource-type.csv to notification-type.csv (#54)
d93c32e
@tomkralidis tomkralidis mentioned this issue Sep 25, 2023
Merged
@tomkralidis
Copy link
Collaborator Author

PR in #56

tomkralidis added a commit that referenced this issue Sep 26, 2023
@tomkralidis
Update and rename resource-type.csv to notification-type.csv (#54) (#56)
e89a7f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkralidis tomkralidis

Labels
None yet
Projects
None yet
Milestone
INFCOM-3
Development

Successfully merging a pull request may close this issue.

Update and rename resource-type.csv to notification-type.csv (#54) wmo-im/wis2-topic-hierarchy
1 participant
@tomkralidis