Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read missing value from CSV2BUFR_MISSING_VALUE #144

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Read missing value from CSV2BUFR_MISSING_VALUE #144

merged 5 commits into from
Jan 9, 2025

Conversation

david-i-berry
Copy link
Member

2 new environment variables

  • CSV2BUFR_MISSING_VALUE: value used to indicate missing data (in addition to "NA", "NaN", "NAN", "None", "", None)
  • BUFR_TABLE_VERSION: bufr table version number to use by default, if not set defaults to 41 (latest supported by base image)

maaikelimper
maaikelimper requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation to mention the new env variables along with some explanation: how they are used in the encoding, default values used when not set...

@maaikelimper
Copy link
Collaborator

The documentation in your PR says:
CSV2BUFR_TEMPLATES: Path to search for BUFR templates, defaults to /opt/csv2bufr/templates.

But from the code it looks like '/opt/csv2bufr/templates' is always added as a search path for templates and the env variable provided an additional local path

@tomkralidis tomkralidis merged commit 36afaba into main Jan 9, 2025
10 checks passed
@tomkralidis tomkralidis deleted the msng-values branch January 9, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaikelimper maaikelimper maaikelimper requested changes

@tomkralidis tomkralidis tomkralidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-i-berry @maaikelimper @tomkralidis