Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved warnings / error handling. #117

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Improved warnings / error handling. #117

merged 4 commits into from
Sep 1, 2023

Conversation

david-i-berry
Copy link
Member

  • warnings now returned as part of result object.
  • removal of duplicate error messages caused by md5 calculation.
  • data no longer written to error log on warning / error, now written to debug.

- as_bufr removed from hash function, now only called once (removal of duplicate messages).
- data now written to debug and only summary to errors / warnings.
- dependency on csv2bur-templates package
- installed templates are now loaded by the CLI from this package rather tha csv2bufr
@maaikelimper
Copy link
Collaborator

maaikelimper commented Aug 31, 2023

the cli appears to be broken:

# csv2bufr --version
Traceback (most recent call last):
  File "/usr/local/bin/csv2bufr", line 5, in <module>
    from csv2bufr.cli import cli
  File "/usr/local/lib/python3.8/dist-packages/csv2bufr/cli.py", line 29, in <module>
    import csv2bufr_templates as c2bt
ModuleNotFoundError: No module named 'csv2bufr_templates'

@david-i-berry
Copy link
Member Author

david-i-berry commented Sep 1, 2023

the cli appears to be broken:

# csv2bufr --version
Traceback (most recent call last):
  File "/usr/local/bin/csv2bufr", line 5, in <module>
    from csv2bufr.cli import cli
  File "/usr/local/lib/python3.8/dist-packages/csv2bufr/cli.py", line 29, in <module>
    import csv2bufr_templates as c2bt
ModuleNotFoundError: No module named 'csv2bufr_templates'

Have you installed the csv2bufr_templates module? At the moment (until I upload to PyPI):

pip3 install --no-cache-dir git+https://github.com/wmo-im/csv2bufr-templates@main

@david-i-berry david-i-berry merged commit 9f3b18e into main Sep 1, 2023
6 checks passed
@david-i-berry david-i-berry deleted the warnings branch September 1, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants