Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

219 new #307

Merged
merged 13 commits into from
Jan 31, 2025
Merged

219 new #307

merged 13 commits into from
Jan 31, 2025

Conversation

amilan17
Copy link
Member

@amilan17 amilan17 commented Jan 31, 2025 •
edited
Loading

#219 - backfill octets, make sure .txt and .xml don't contain octetCount

antoinemerle and others added 11 commits January 14, 2025 11:50
@antoinemerle
Update create_master_lists.py
5646f0d 
as requested in :

- #219

>In GRIB2 Template definition files the octet number (from - to) for each entry in the GRIB section is given.
Most of the GRIB processing software packages need the length or number of octets for each entry, which has to be calculated from the specification of "OctetNo".
But with variables and repitition within some templates an automated calculation is sometimes not easy. (e.g. 37 + (ND-1)*4 + (NF-1)*4 -40 +(ND-1)*4 + (NF-1)*4)
Therefore, this is a proposal to add a column with the length of each entry in the GRIB2_Template files.
@antoinemerle
Update create_master_lists.py
f83737c 
remove any keys not in 'fieldnames' to avoid ValueError
@efucile
xml,txt files
203131a
@antoinemerle
Update create_master_lists.py
4e1a5d0 
make the count to be computed when the limit is not fixed but variable
@efucile
xml,txt files
8990ef6
@antoinemerle
run the script update_octetcount.py to update the OctetCount number f…
b88e9a1 
…or all templates. the script will be added in the issue #219
@antoinemerle
Replace Length per octetCount and remove it from the xml
a302273
@efucile
xml,txt files
898145c
@antoinemerle
remove the octetCount in the txt and from the CI/CD
426c119
@antoinemerle
update the create_master to avoid any issue while populating fields i…
d4609ce 
…n the xml and txt
@antoinemerle
update the create_master to avoid any issue while populating fields i…
d665313 
…n the xml and txt
@amilan17 amilan17 linked an issue Jan 31, 2025 that may be closed by this pull request
Additional entry of length or number of octets in GRIB2_Template_ csv-files #219
Closed
@amilan17 amilan17 merged commit ea4c75a into master Jan 31, 2025
@amilan17 amilan17 deleted the 219-NEW branch January 31, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional entry of length or number of octets in GRIB2_Template_ csv-files
3 participants
@amilan17 @antoinemerle @efucile