Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameters in Code Table 4.2 #286

Closed
sebvi opened this issue Nov 10, 2024 · 10 comments · Fixed by #293
Closed

New parameters in Code Table 4.2 #286

sebvi opened this issue Nov 10, 2024 · 10 comments · Fixed by #293

Comments

@sebvi
Copy link
Contributor

sebvi commented Nov 10, 2024

Initial request

The parameter “Live fuel moisture content” (discipline=2, parameter category=4, parameter number =31) can be subdivided into a component for low and high vegetation. We propose to add these two additional entries.

The Obukhov Length (L) is a well-established parameter in boundary layer meteorology. We propose to add the reciprocal Obukhov length (1/L) because L can be infinite in certain cases of neutral stability.

ECMWF is also requesting a set of ocean parameters needed for our latest development so that more of the ocean output portfolio can be made available in GRIB. Note that due to the organisation of the oceanography discipline, we need to request the same parameter in 3 different categories.

Amendment details

ADD to code table 4.2: Product discipline 2 , parameter category 4

Code Description Unit
37 Live fuel moisture content in low vegetation kg kg-1
38 Live fuel moisture content in high vegetation kg kg-1

ADD to code table 4.2: Product discipline 0 , parameter category 7

Code Description Unit
21 Reciprocal Obukhov length m-1

ADD to Code table 4.2: Product discipline 0, parameter category 4

Code Description Unit
63 Diffuse short-wave radiation flux, clear sky W m-2

ADD to code table 4.2: Product discipline 10, parameter category 2

Code Description Unit
31 Downward short-wave radiation flux W m-2

ADD to code table 4.2: Product discipline 10, parameter category 3

Code Description Unit
22 Downward short-wave radiation flux W m-2

ADD to code table 4.2: Product discipline 10, parameter category 4

Code Description Unit
55 Sea water upward volume transport m3 m-2 s-1
56 Sea water upward mass transport kg m-2 s-1
57 Sea water age since surface contact s
58 Sea water downward short-wave radiation flux W m-2

Comments

No response

Requestor(s)

Sebastien Villaume (ECMWF) 
Robert Osinski (ECMWF) 
Matthew Griffith (ECMWF) 

Stakeholder(s)

ECMWF

Publication(s)

Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 2, category 4 (update) 
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 0, category 7 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 0, category 4 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 10, category 3 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 10, category 3 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 10, category 4 (update)

Expected impact of change

None

Collaborators

No response

References

No response

Validation

No response

@sebvi sebvi self-assigned this Nov 10, 2024
@amilan17
Copy link
Member

https://github.com/wmo-im/tt-tdcf/wiki/2024.11.12.tt.tdcf notes:

  • Sebastien introduced the proposal
  • these parameters have been encoded in NetCDF and the NEMO ocean model at ECMWF
  • Sibylle suggested adding a new category under discipline 10 instead of repeating parameters in multiple categories

@amilan17 amilan17 moved this from Submitted to In progress in GRIB2 Amendments Nov 12, 2024
@amilan17 amilan17 added this to the FT2025-1 milestone Nov 12, 2024
@amilan17
Copy link
Member

amilan17 commented Dec 3, 2024

https://github.com/wmo-im/tt-tdcf/wiki/2024.11.12.tt.tdcf notes:
Matthew explained the problem with adding a new category would require deprecation of the other parameters; Sibylle noted that it would be better to add a note to use the values in the new category instead because this would set a better practice; Jeff noted that the combination of discipline/category/parameter defines the uniqueness of the parameter;

  • need comments from the ocean community on the repetition of parameters across different 4.2 tables before 20 December: @david-i-berry and Matthew will reach out to NEMO

@sebvi
Copy link
Contributor Author

sebvi commented Dec 20, 2024

This is the comment we received about classifying parameters in oceanography:

Pablo Ortega BSC:
I'm not sure it is worth changing the classification.
From the list [of possible additional NEMO parameters] it seems that most of them are surface fluxes, which share very similar characteristics in terms of vertical location, so it would be wise to group them according to that criteria, which I understand is the current one, right? The same applies to the integrated ocean variables.

sebvi added a commit that referenced this issue Dec 23, 2024
@sebvi
Copy link
Contributor Author

sebvi commented Jan 5, 2025

Updating entry numbers in code Table 4.2.10.4 as the entries were already assigned

sebvi added a commit that referenced this issue Jan 5, 2025
@sebvi
Copy link
Contributor Author

sebvi commented Jan 10, 2025

branch is updated

@amilan17
Copy link
Member

https://github.com/wmo-im/et-data/wiki/2025.01.14.et.data notes:
ready for review, validation not necessary

@amilan17 amilan17 moved this from In progress to In validation / review in GRIB2 Amendments Jan 14, 2025
@amilan17 amilan17 linked a pull request Jan 16, 2025 that will close this issue
@amilan17
Copy link
Member

@sebvi

Image

@sebvi
Copy link
Contributor Author

sebvi commented Jan 22, 2025

oh I should move it to 31 then

@sebvi
Copy link
Contributor Author

sebvi commented Jan 22, 2025

moved to 31, branch updated

@amilan17
Copy link
Member

I also changed "Reciprocal Obukhov length" to 22.

amilan17 added a commit that referenced this issue Jan 23, 2025
* issue #286 adding new code table entries

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

* #issue 286 moving downward short-wave radiation flux from entry 30 to 31 in Code table 4.2.10.2

* Update GRIB2_CodeFlag_4_2_2_4_CodeTable_en.csv

---------

Co-authored-by: Sebastien Villaume <[email protected]>
@amilan17 amilan17 moved this from In validation / review to Validated in GRIB2 Amendments Jan 23, 2025
amilan17 added a commit that referenced this issue Jan 29, 2025
…and 42 and new code table 4253 (#294)

* issue #286 adding new category for hazards in discipline 20 and associated Code table 4.2 entries

* issue #285 adding new Code Table 4.253

* #issue 285: editorial change in code table 4.2.20.4 and 4.2.20.5 to remove capital letters, modified code table 4.253

* Update GRIB2_CodeFlag_4_2_20_4_CodeTable_en.csv

* fix csv

---------

Co-authored-by: Sebastien Villaume <[email protected]>
@github-project-automation github-project-automation bot moved this from Validated to Ready for FT approval procedure in GRIB2 Amendments Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for FT approval procedure
Development

Successfully merging a pull request may close this issue.

2 participants