Expand Flash Message Tests, Resolve Additional Issues, and simplify otp_set_flash_message #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, please rebase |
… messages do not persist to next controller action (failing);
… immediately too (resolves test failures);
…essage functionality;
strouptl
force-pushed
the
expand_flash_tests
branch
from
4e16540 to
ba23931
Compare
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #95, I decided to work on adding flash tests inline with the existing controller tests. In doing so, I found two additional cases like issue #94, where the flash message was persisting incorrectly to the next view.
In addition, I realized that we can greatly simplify the otp_set_flash_message method via the existing Devise set_flash_message functionaliy. And with the flash test coverage in place, I think we can safely make this change.
This PR accomplishes the following:
NOTE: This PR assumes PR #95, so please merge that PR first.