Fix issue with scoped redirects for non-default resources #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edirected to properly scoped path (rather than the default scope);
…(rather than just the default scope);
…rom default (user) routes going forward;
|
@strzibny, I made one more commit, reversing the order of the admin and user routes in the test app. This will eliminate false positives in the tests from the default (user) routes like this going forward. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paweld-iRonin discovered an issue (#86) where the non-default resource was being redirected to the default resource's routes within the otp_tokens_controller. The underlying problem is that simply calling "redirect_to :show" in the otp_tokens_controller redirects to the default scope, rather than getting the proper scope for that resource.
This issue is a hold over from before, when we were only using one resource, and it was not reflected in tests, as the user scope is the default anyway. However, it can be reproduced by reversing the order of the "devise_for" additions for users and admins in the routes file of the test app.
This PR resolves the immediate issue, along with the attendant "Disable OTP" link issue.