Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGED: Update supported Rails version to v7.2 #87

Merged
merged 2 commits into from
Aug 15, 2024
Merged

CHANGED: Update supported Rails version to v7.2 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148ee31
CHANGED: Update supported Rails version to v7.2
tarellel Aug 10, 2024
ef05170
CHANGED: Resolve ActiveRecord migratioon issue
tarellel Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Upgrade gemspec to support Rails v7.2

## 0.7.0

Breaking changes:
Expand Down Expand Up @@ -57,4 +61,3 @@ Fixes:

- mandatory otp fix by @cotcomsol in #68
- remove success message by @strzibny in #69

2 changes: 1 addition & 1 deletion devise-otp.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
gem.files = `git ls-files`.split($/)
gem.require_paths = ["lib"]

gem.add_runtime_dependency "rails", ">= 6.1", "< 7.2"
gem.add_runtime_dependency "rails", ">= 6.1", "<= 7.2"
gem.add_runtime_dependency "devise", ">= 4.8.0", "< 5.0"
gem.add_runtime_dependency "rotp", ">= 2.0.0"

Expand Down
7 changes: 6 additions & 1 deletion test/orm/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,9 @@

migrations_path = File.expand_path("../../dummy/db/migrate/", __FILE__)

ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration).migrate
if Rails.version.to_f >= 7.2
ActiveRecord::MigrationContext.new(migrations_path).migrate
else
# To support order versions of Rails (pre v7.2)
ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration).migrate
end
Loading