Add "Reset" button, and repurpose/hide "Disable" button for Mandatory OTP #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a changelog entry |
|
Sure thing! I will add a changelog entry and update the test specs. |
strouptl
force-pushed
the
hide_disable_mandatory_otp
branch
from
f46de74 to
0615fb5
Compare
|
Good to go. |
… whether mandatory OTP is missing;
- update disable action to preserve existing OTP token; - move disable button to bottom of otp_tokens#show page;
- add test to ensure that disable preserves existing token secrets; - move existing token tests to disable_token for clarity;
strouptl
force-pushed
the
hide_disable_mandatory_otp
branch
from
45e1017 to
3cf94b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@strzibny, I am interested in adding a Reset button and reporposing/hiding the Disable button. Changes as follows:
What do you think? Let me know if you agree, and I will add tests for the change.