Code

Confirm OTP Token#72

Code

Merged

strzibny merged 28 commits intowmlele:masterwmlele/devise-otp:masterfrom strouptl:confirm_otp_tokenstrouptl/devise-otp:confirm_otp_tokenCopy head branch name to clipboardMay 20, 2024

+262-94

Commits

Commits on May 18, 2024

• scaffold solution for confirming OTP before enabling OTP;

  strouptl

  committed
  a83a5dd

  Copy full SHA for a83a5dd

• Add instructions to confirm_otp_token form;

  strouptl

  committed
  e3b929d

  Copy full SHA for e3b929d

• move "Enable Authentication" form to separate "edit" view; reduce "show" view to display link to form if otp is disabled;

  strouptl

  committed
  f960474

  Copy full SHA for f960474

• use existing edit/update actions on otp_tokens controller for confirming/enabling Two-Factor-Authentication (rather than separate otp_confirm_tokens);

  strouptl

  committed
  01a402f

  Copy full SHA for 01a402f

• remove token explanation from show page;

  strouptl

  committed
  cc9067e

  Copy full SHA for cc9067e

• update flash message for failed confirmation;

  strouptl

  committed
  fed4602

  Copy full SHA for fed4602

• move locales for OTP confirmation form to edit_otp_tokens scope; delete unneeded values;

  strouptl

  committed
  fab7c1c

  Copy full SHA for fab7c1c

• differentiate title of show and edit pages; move "title" value for edit_otp_tokens to "lead_in";

  strouptl

  committed
  7920bd3

  Copy full SHA for 7920bd3

• revert method name to enable_top!;

  strouptl

  committed
  5ba39da

  Copy full SHA for 5ba39da

• revert "h2" for otp_tokens#show to locale file;

  strouptl

  committed
  7074c2f

  Copy full SHA for 7074c2f

• use enable_link config locale in otp_tokens#show;

  strouptl

  committed
  2b3f893

  Copy full SHA for 2b3f893

• use locales for otp_token field and submit button; switch terminology to "Verification Code";

  strouptl

  committed
  ffdf493

  Copy full SHA for ffdf493

• match terminology to AWS MFA form;

  strouptl

  committed
  ebd03ca

  Copy full SHA for ebd03ca

• replace remaining reference to "Verification Code";

  strouptl

  committed
  debe1c1

  Copy full SHA for debe1c1

• add tests for enabling two-factor authentication via dedicated otp_token#edit action;

  strouptl

  committed
  f30aa59

  Copy full SHA for f30aa59

• update test helpers and initial sign_in test for new Enable Two-Factor Authentication form;

  strouptl

  committed
  0a9dc5a

  Copy full SHA for 0a9dc5a

• update otp_tokens#update to redirect to show action as before (rather than redirecting via otp_credential_path);

  strouptl

  committed
  8bc2b83

  Copy full SHA for 8bc2b83

• update disable test to confirm correct status displayed; remove accept_confirm block (not needed);

  strouptl

  committed
  074b67e

  Copy full SHA for 074b67e

• update EnableOtpForm tests to reload user before checking whether OTP was enabled, and to check for actual page content rather than flash message content for reliability;

  strouptl

  committed
  1e94af0

  Copy full SHA for 1e94af0

Commits on May 19, 2024

• add populate_otp! method for populating initial secrets; add instructions to README for existing users;

  strouptl

  committed
  61f46a2

  Copy full SHA for 61f46a2

• update otp_tokens controller to populate otp secrets as needed; rename method to "populate_otp_secrets!", replace reset_otp_credentials! method with destroy_otp_secrets!, and remove "on create" cal…

  Show description for e9215f4
  strouptl

  committed
  e9215f4

  Copy full SHA for e9215f4

• update button text and warnings for disabling 2FA; remove instructions for existing users from README (no longer needed);

  strouptl

  committed
  747cefa

  Copy full SHA for 747cefa

• update tests for change; add otp_failed_attempts to destroy_otp_secrets! method;

  strouptl

  committed
  3293345

  Copy full SHA for 3293345

• rename destroy_otp_secrets! to clear_otp_fields! for consistency (since it includes counters and challenges as well);

  strouptl

  committed
  dfe9d45

  Copy full SHA for dfe9d45

• simplify populate_otp_secrets! method;

  strouptl

  committed
  0ca939f

  Copy full SHA for 0ca939f

Commits on May 20, 2024

• draft CHANGELOG insertion for requiring confirmation token and populating OTP secrets as needed;

  strouptl

  committed
  51dca03

  Copy full SHA for 51dca03

• rename "otp_token" input to "confirmation_code"; make edit_otp_token scope singular; fix spelling issue in "Enable Two Factor Authentication" link; expand "Changes to Locales" description in CHANGE…

  Show description for 04fa4a7
  strouptl

  committed
  04fa4a7

  Copy full SHA for 04fa4a7

• Update CHANGELOG.md to fix list indentation issue;

  

  Laney Stroup

  authored
  8cbc133

  Copy full SHA for 8cbc133