CHANGED: Update supported Rails version to v7.2 (#87)

* CHANGED: Update supported Rails version to v7.2 * CHANGED: Resolve ActiveRecord migratioon issue
wmlele · Aug 15, 2024 · ccdfb7d · ccdfb7d
1 parent 626f156
commit ccdfb7d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Upgrade gemspec to support Rails v7.2
+
 ## 0.7.0
 
 Breaking changes:
@@ -57,4 +61,3 @@ Fixes:
 
 - mandatory otp fix by @cotcomsol in #68
 - remove success message by @strzibny in #69
-
diff --git a/devise-otp.gemspec b/devise-otp.gemspec
@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
   gem.files = `git ls-files`.split($/)
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency "rails", ">= 6.1", "< 7.2"
+  gem.add_runtime_dependency "rails", ">= 6.1", "<= 7.2"
   gem.add_runtime_dependency "devise", ">= 4.8.0", "< 5.0"
   gem.add_runtime_dependency "rotp", ">= 2.0.0"
 

diff --git a/test/orm/active_record.rb b/test/orm/active_record.rb
@@ -3,4 +3,9 @@
 
 migrations_path = File.expand_path("../../dummy/db/migrate/", __FILE__)
 
-ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration).migrate
+if Rails.version.to_f >= 7.2
+  ActiveRecord::MigrationContext.new(migrations_path).migrate
+else
+  # To support order versions of Rails (pre v7.2)
+  ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration).migrate
+end