Add support for Rails 8, use Appraisal to test gem against older Rail…

…s versions (#100)

See svenfuchs/rails-i18n#1130 (comment) for
upper constraint removal

.github/workflows/ci.yml

@@ -16,6 +16,17 @@ jobs:
           - '3.2'
           - '3.1'
           - 'head'
+        rails:
+          - rails_8.0
+          - rails_7.2
+          - rails_7.1
+          - rails_7.0
+        exclude:
+          - ruby: '3.1'
+            rails: 'rails_8.0'
+
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.rails }}.gemfile
 
     steps:
       - name: Checkout

.gitignore

@@ -38,7 +38,9 @@ test/dummy/db/*.sqlite3
 test/dummy/db/*.sqlite3-shm
 test/dummy/db/*.sqlite3-wal
 
+# Ignore Gemfile.lock
 Gemfile.lock
+gemfiles/*.lock
 
 # Generated test files
 tmp/*

Appraisals

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+appraise 'rails_7.0' do
+  gem 'rails', '~> 7.0.0'
+  gem 'sqlite3', '~> 1.5.0'
+
+  # Fix: LoadError: cannot load such file -- base64
+  install_if '-> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.3.0") }' do
+    gem 'base64'
+    gem 'bigdecimal'
+    gem 'mutex_m'
+    gem 'drb'
+    gem 'logger'
+  end
+end
+
+appraise 'rails_7.1' do
+  gem 'rails', '~> 7.1.0'
+  gem 'sqlite3', '~> 1.5.0'
+
+  # Fix:
+  # warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0.
+  # Add logger to your Gemfile or gemspec.
+  install_if '-> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0") }' do
+    gem 'logger'
+  end
+end
+
+appraise 'rails_7.2' do
+  gem 'rails', '~> 7.2.0'
+  gem 'sqlite3', '~> 1.5.0'
+end
+
+appraise 'rails_8.0' do
+  gem 'rails', '~> 8.0.0'
+end

Gemfile

@@ -3,12 +3,14 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in devise-otp.gemspec
 gemspec
 
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+
 gem "capybara"
 gem "minitest-reporters", ">= 0.5.0"
 gem "puma"
 gem "rake"
 gem "rdoc"
 gem "shoulda"
 gem "sprockets-rails"
-gem "sqlite3", "~> 1.4"
+gem "sqlite3", "~> 2.1"
 gem "standardrb"

devise-otp.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
   gem.files = `git ls-files`.split($/)
   gem.require_paths = ["lib"]
 
-  gem.add_dependency "rails", ">= 7.0", "< 9.0"
+  gem.add_dependency "rails", ">= 7.0"
   gem.add_dependency "devise", ">= 4.8.0", "< 5.0"
   gem.add_dependency "rotp", ">= 2.0.0"
   gem.add_dependency "rqrcode", "~> 2.0"

gemfiles/rails_7.0.gemfile

@@ -0,0 +1,25 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+gem "capybara"
+gem "minitest-reporters", ">= 0.5.0"
+gem "puma"
+gem "rake"
+gem "rdoc"
+gem "shoulda"
+gem "sprockets-rails"
+gem "sqlite3", "~> 1.5.0"
+gem "standardrb"
+gem "rails", "~> 7.0.0"
+
+install_if -> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.3.0") } do
+  gem "base64"
+  gem "bigdecimal"
+  gem "mutex_m"
+  gem "drb"
+  gem "logger"
+end
+
+gemspec path: "../"

gemfiles/rails_7.1.gemfile

@@ -0,0 +1,21 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+gem "capybara"
+gem "minitest-reporters", ">= 0.5.0"
+gem "puma"
+gem "rake"
+gem "rdoc"
+gem "shoulda"
+gem "sprockets-rails"
+gem "sqlite3", "~> 1.5.0"
+gem "standardrb"
+gem "rails", "~> 7.1.0"
+
+install_if -> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0") } do
+  gem "logger"
+end
+
+gemspec path: "../"

gemfiles/rails_7.2.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+gem "capybara"
+gem "minitest-reporters", ">= 0.5.0"
+gem "puma"
+gem "rake"
+gem "rdoc"
+gem "shoulda"
+gem "sprockets-rails"
+gem "sqlite3", "~> 1.5.0"
+gem "standardrb"
+gem "rails", "~> 7.2.0"
+
+gemspec path: "../"

gemfiles/rails_8.0.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
+gem "capybara"
+gem "minitest-reporters", ">= 0.5.0"
+gem "puma"
+gem "rake"
+gem "rdoc"
+gem "shoulda"
+gem "sprockets-rails"
+gem "sqlite3", "~> 2.1"
+gem "standardrb"
+gem "rails", "~> 8.0.0"
+
+gemspec path: "../"

test/dummy/db/migrate/20240604000001_create_admins.rb

@@ -1,4 +1,4 @@
-class CreateAdmins < ActiveRecord::Migration[7.1]
+class CreateAdmins < ActiveRecord::Migration[5.0]
   def change
     create_table :admins do |t|
       t.string :name