Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM ADM0 #2963

Merged
merged 4 commits into from
Oct 5, 2023
Merged

SPM ADM0 #2963

merged 4 commits into from
Oct 5, 2023

Conversation

leeberryman
Copy link
Contributor

Thanks @alex-imb!

SPM ADM0 This is digitized from Sentinel2 imagery.

Why do we need this boundary?

#2961

Anything Unusual?

@DanRunfola
Copy link
Member

Thanks Lee! Going to have our Data Engineer work on this - may have to redo the PR so it kicks off our bot (not quite sure why it didn't in this case, so going to check).

@rohith4444
Copy link
Collaborator

Hello @leeberryman,

No files have been altered in the commit. We're uncertain how this pull request was generated without any file modifications.

@leeberryman
Copy link
Contributor Author

@rohith4444 I took a branch on @alex-imb's fork and pulled it into my branch on geoboundaries SPM ADM0 and created a pull request from this branch to main. Can you see the additional files?

@DanRunfola
Copy link
Member

@leeberryman looks like the files themselves aren't being included in some step here - i.e., the diff itself is "0", indicating that no changes are present from this commit vs. the gB main. My guess is this has somethign to do with our use of LFS, and how that might interact with a fork that doesn't have LFS installed?

I added @alex-imb to the collaborators list, so I think they'll be able to commit direclty now.

@leeberryman
Copy link
Contributor Author

Thanks @DanRunfola, @alex-imb will go ahead and make a new commit.

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for geometryDataChecks

OVERALL STATUS: 2 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: You submitted at least one file that is missing a meta.txt, which is required. Please make sure your meta.txt is in the root of your submitted zip file - I have not yet been programmed to look in folders for your meta.txt.
Full logs for fileChecks

geometryDataChecks: All checks PASSED. Nothing that needs to be done here right now.
Full logs for geometryDataChecks

metaChecks: It looks like your metadata has one or more errors - take a look at the logs to see what you need to fix.
Full logs for metaChecks

----- Preview -----
Preview

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for geometryDataChecks

Full logs for metaChecks

All checks have passed! I'll flag your boundary submission for a manual review by one of my humans.
Preview

@jingjli1
Copy link
Collaborator

Looks good!

@jingjli1 jingjli1 closed this Sep 29, 2023
@jingjli1 jingjli1 reopened this Sep 29, 2023
Copy link
Collaborator

@jingjli1 jingjli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for geometryDataChecks

Full logs for metaChecks

All checks have passed! I'll flag your boundary submission for a manual review by one of my humans.
Preview

@jingjli1 jingjli1 closed this Sep 29, 2023
@jingjli1 jingjli1 reopened this Sep 29, 2023
@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for geometryDataChecks

Full logs for metaChecks

All checks have passed! I'll flag your boundary submission for a manual review by one of my humans.
Preview

@DanRunfola DanRunfola merged commit 3da992e into main Oct 5, 2023
8 checks passed
@DanRunfola DanRunfola deleted the SPM_ADM0 branch October 5, 2023 19:55
@alex-imb alex-imb mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants