Add aria-required attribute to Lookup, LookupInput #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Draft for now, in case we break down T313113 tomorrow and this commit should be attached to a subtask.) (Edit: We did.) |
We want to add this attribute to lookups on the new lexeme special page, and adding it to the surrounding <div> isn’t enough. Bug: T313891
lucaswerkmeister
force-pushed
the
aria-required
branch
from
b391b11 to
6bb18fe
Compare
chukarave
pushed a commit
that referenced
this pull request
Jul 28, 2022
We want to add this attribute to lookups on the new lexeme special page, and adding it to the surrounding <div> isn’t enough. Bug: T313891
chukarave
pushed a commit
that referenced
this pull request
Jul 28, 2022
We want to add this attribute to lookups on the new lexeme special page, and adding it to the surrounding <div> isn’t enough. Bug: T313891
lucaswerkmeister
pushed a commit
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add this attribute to lookups on the new lexeme special page, and adding it to the surrounding
<div>isn’t enough.Bug: T313891