Update Payments to version 8 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payments in version 8 removed the `LegacyPaymentStatus` class and the property from the `LegacyPaymentData` class. Since the donation status in the database is still in use in the Fundraising Operation Center and was derived from LegacyPaymentStatus, we have implemented the mapping in the donation domain, to be able to remove it later, when ticket https://phabricator.wikimedia.org/T359954 is done. This is not a backwards-breaking change, because public APIs are not affected.
Abban
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payments in version 8 removed the
LegacyPaymentStatusclass andthe property from the
LegacyPaymentDataclass. Since the donationstatus in the database is still in use in the Fundraising Operation
Center and was derived from LegacyPaymentStatus, we have implemented the
mapping in the donation domain, to be able to remove it later, when
ticket https://phabricator.wikimedia.org/T359954 is done.
This is not a backwards-breaking change, because public APIs are not
affected.