Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👮 Add a few property based tests stressing template parameter packs. #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukevalenty
Copy link

Added a few property based tests that will really stress out template parameter packs....sorry @wlav! 😅 Requires hypothesis python module. This is the same module and methodology I am using to test some of Intel's open source C++ libraries with.

https://hypothesis.readthedocs.io/en/latest/

@lukevalenty
Copy link
Author

This will exercise the bugs in both #261 and #262.

@lukevalenty lukevalenty force-pushed the add_random_template_tests branch from 0e572cd to 3a40d5c Compare October 1, 2024 18:54
@wlav
Copy link
Owner

wlav commented Oct 3, 2024

Always in favor of more tests, albeit that yes, I'm using mostly bare, ancient style. I'll need to add hypothesis as an optional package to the requirements for a test (or dev) target and also prefer to give each set of tests a unique namespace to prevent spurious clashes (not too bad for functions as is the case here, as they're just overloads, but classes can't be redefined).

@lukevalenty
Copy link
Author

I can update the PR and put the tests into a class, as well as the template fix you gave me in the other issue I filed.

@lukevalenty lukevalenty force-pushed the add_random_template_tests branch from 3a40d5c to b5d1fe4 Compare October 3, 2024 02:56
@lukevalenty
Copy link
Author

I'll need to add hypothesis as an optional package to the requirements for a test (or dev) target

I put the tests in their own namespace, but wasn't quite sure how to setup the requirements for hypothesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants